Skip to content

Conversation

@colinrotherham
Copy link
Contributor

Description

This PR upgrades to ESLint v9 now that all packages are compatible

Previously in #530 we were only able to use ESLint v8

Checklist

  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • CHANGELOG entry

@frankieroberto
Copy link
Contributor

@colinrotherham would you mind shifting this work across to target https://github.com/nhsuk/nhsuk-prototype-kit-package instead? That repo contains the kit extracted as an NPM package. It currently has prettier set up, but not ESLint yet.

My current thinking is that once the npm package is released, this template repo would be updated to use it, and would no longer itself containing any linting or tests. (Although users could choose to add them if they prefer). See #688 for work in progress.

@frankieroberto
Copy link
Contributor

@colinrotherham I’ve had a go at doing this at nhsuk/nhsuk-prototype-kit-package#41

Mind if I close this for now? Assuming we can upgrade to v8 fairly soon, this PR would become redundant as the template repo wouldn’t have linting set up.

@colinrotherham
Copy link
Contributor Author

Up to you. There's still value in merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants