feat: Add custom element manifest to build#35
feat: Add custom element manifest to build#35fredvisser wants to merge 3 commits intoarchives/fast-element-1from
Conversation
| * Custom Elements Manifest analyzer plugins for @ni/fast-element patterns. | ||
| * | ||
| * The standard CEM analyzer doesn't know about FAST's @attr decorator, so we | ||
| * teach it here. One plugin is exported: | ||
| * | ||
| * - attrDecoratorPlugin – maps @attr-decorated properties to CEM attributes | ||
| * | ||
| * Note: fast-foundation components are base classes registered by consumers | ||
| * (e.g. nimble-components). They do not declare HTMLElementTagNameMap entries, | ||
| * so no tag-name plugin is needed here. |
There was a problem hiding this comment.
The standard CEM analyzer doesn't know about FAST's @attr decorator
It certainly seems to:
what's the story here?
There was a problem hiding this comment.
Would be interested in understanding why we can't just use the cli with the --fast flag
There was a problem hiding this comment.
Looks like the cli works fine: #36
Will merge that and also add to nimble on innovation days
But also chatted with @fredvisser offline and goal was integrator support. Will try to instead lean towards having good Angular app template generation with tooling / agents config out of the box something like steps to run after ng new or if ng new supports templating or angular schematics, etc.
edit: the results of #36 / #37 : https://unpkg.com/@ni/fast-foundation@10.2.1/dist/custom-elements.json
|
Closing in favor of #35 |
2 participants
Pull Request
📖 Description
Related to ni/nimble#2704, this PR adds a custom elements manifest to the ni/fast package. "This format [allows] tooling and IDEs to give rich information about the custom elements in a given project."
🎫 Issues
👩💻 Reviewer Notes
@wc-toolkit/cem-validatorto generally validate built CEM correctness, but haven't included any validation in the PR. Happy to add that, or other validation into this PR.📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps