grpc_generator: Continue using mypy-protobuf 3.6 until we drop support for protobuf v4 #250
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an upper bound constraint on the mypy-protobuf dependency to keep it at version 3.6.x, ensuring continued compatibility with protobuf v4. The change prevents automatic upgrades to mypy-protobuf 3.7.0+, which requires protobuf v6 at build time and would force generated code to also require protobuf v6. This is critical since the repository's packages standardize on protobuf >=4.21 (v4).
Key Changes
- Constrained mypy-protobuf to
>=3.6,<3.7with clear documentation explaining the rationale - Updated poetry.lock to reflect the new constraint and add Python 3.8 wheel entries for PyYAML
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/grpc_generator/pyproject.toml | Added upper bound <3.7 to mypy-protobuf version constraint with explanatory comment about protobuf v4 compatibility |
| tools/grpc_generator/poetry.lock | Updated lock file with Python 3.8 PyYAML wheels and new content hash reflecting the dependency constraint change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This won't work because Renovate will try to update the version range in pyproject.toml. Example: ni/measurement-plugin-python#1271 |
What does this Pull Request accomplish?
Add upper bound for mypy-protobuf version
Why should this Pull Request be merged?
mypy-protobuf 3.7.0 requires protobuf v6 at build time, which makes the generated code also require protobuf v6.
What testing has been done?
PR build