Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented May 22, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Add a GitHub Actions workflow to publish the nidaqmx package to PyPI using GitHub as a PyPI "Trusted Publisher".

Why should this Pull Request be merged?

Enable publishing the package more easily.

What testing has been done?

Tested in a personal fork of the https://github.com/ni/nitypes-python repo.

@bkeryan bkeryan enabled auto-merge (squash) May 22, 2025 23:43
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Test Results

    34 files  ±0      34 suites  ±0   56m 41s ⏱️ -8s
 2 461 tests ±0   2 091 ✅ ±0    370 💤 ±0  0 ❌ ±0 
43 920 runs  ±0  37 508 ✅ ±0  6 412 💤 ±0  0 ❌ ±0 

Results for commit 384f1a8. ± Comparison against base commit 48379e7.

♻️ This comment has been updated with latest results.

@bkeryan
Copy link
Collaborator Author

bkeryan commented May 23, 2025

FYI @zhindes @maxxboehme My plan is to merge this and then test it by creating a 1.2.0.dev0 release. :)

@bkeryan
Copy link
Collaborator Author

bkeryan commented May 24, 2025

FYI @zhindes @maxxboehme My plan is to merge this and then test it by creating a 1.2.0.dev0 release. :)

Maybe I can test publishing to TestPyPI from a personal fork of the repo... I guess I would have to configure my personal fork as a trusted publisher in TestPyPI.

@bkeryan
Copy link
Collaborator Author

bkeryan commented Jun 4, 2025

Maybe I can test publishing to TestPyPI from a personal fork of the repo... I guess I would have to configure my personal fork as a trusted publisher in TestPyPI.

I tested the actions with TestPyPI using a personal fork of nitypes-python.

@bkeryan bkeryan force-pushed the users/bkeryan/publish-workflow branch from 579947e to 384f1a8 Compare June 4, 2025 23:47
@bkeryan bkeryan merged commit 555b1c0 into master Jun 5, 2025
17 checks passed
@bkeryan bkeryan deleted the users/bkeryan/publish-workflow branch June 5, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants