Revert workaround that skip docs tox env #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lau-yeexuan
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
lau-yeexuan
changed the title
docs tox env fail issuedocs tox env fail issue
lau-yeexuan
changed the title
docs tox env fail issue
lau-yeexuan
changed the title
lau-yeexuan
changed the title
zhindes
requested changes
Nov 17, 2025
Collaborator
zhindes
left a comment
zhindes
left a comment
There was a problem hiding this comment.
PR passes without the workaround applied previously.
Does it? I don't see the PR build running... does it skip based on what changes you're making?
Collaborator
Nevermind, I'm just really blind... |
zhindes
approved these changes
Nov 17, 2025
bkeryan
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Remove
--skip-env docsfrom the tox command lineWhy should this Pull Request be merged?
Fixes #862
AB#3439830
What testing has been done?
PR passes without the workaround applied previously.