Marking hardcoded error message test xfail temporary to update nidaqmxbot#680
Merged
WayneDroid merged 1 commit intoni:masterfrom Mar 14, 2025
tjying95:Mark-hardcoded-error-test-xfail-when-updating-nidaqmxbot
Merged
Marking hardcoded error message test xfail temporary to update nidaqmxbot#680WayneDroid merged 1 commit intoni:masterfrom tjying95:Mark-hardcoded-error-test-xfail-when-updating-nidaqmxbot
WayneDroid merged 1 commit intoni:masterfrom
tjying95:Mark-hardcoded-error-test-xfail-when-updating-nidaqmxbot
Conversation
Signed-off-by: Jun Ying Tan <9677893+tjying95@users.noreply.github.com>
bkeryan
approved these changes
Mar 13, 2025
WayneDroid
approved these changes
Mar 14, 2025
tjying95
deleted the
Mark-hardcoded-error-test-xfail-when-updating-nidaqmxbot
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
There are some whitespace and new line changes in the latest version of DAQmx driver regarding this error code
DAQmxErrors.SAMPLES_NOT_YET_AVAILABLE.This causes failure when updating
nidaqmxbotsince this test is failing:test___error_code_with_hardcoded_error_message___get_error_string___returns_hardcoded_error_messageWhy should this Pull Request be merged?
xfailing the test temporary so that nidaqmxbot can be updated.
What testing has been done?
Locally tested with latest NI-DAQmx driver and test is
xpassed.