Skip to content

Refactor tests for stream readers into smaller files#817

Merged
mikeprosserni merged 2 commits intomasterfrom
users/mprosser/stream-test-cleanup
Sep 3, 2025
Merged

Refactor tests for stream readers into smaller files#817
mikeprosserni merged 2 commits intomasterfrom
users/mprosser/stream-test-cleanup

Conversation

@mikeprosserni
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Along the same lines as my other PR #816, this splits up large test files into smaller more manageable test files. It also moves common helper functions into a conftest.py.

Why should this Pull Request be merged?

This should make reviewing future changes easier.

What testing has been done?

All the tests pass.

@mikeprosserni mikeprosserni marked this pull request as ready for review September 2, 2025 20:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Test Results

    38 files  ±0      38 suites  ±0   1h 2m 23s ⏱️ +49s
 2 675 tests ±0   2 232 ✅ ±0    443 💤 ±0  0 ❌ ±0 
47 382 runs  ±0  40 226 ✅ ±0  7 156 💤 ±0  0 ❌ ±0 

Results for commit 3c20f09. ± Comparison against base commit 859c18d.

This pull request removes 296 and adds 296 tests. Note that renamed tests count towards both.
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[library_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_many_sample___returns_valid_samples[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_many_sample___returns_valid_samples[library_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_many_sample_with_wrong_dtype___raises_error_with_correct_dtype[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_many_sample_with_wrong_dtype___raises_error_with_correct_dtype[library_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_one_sample___returns_valid_samples[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_one_sample___returns_valid_samples[library_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_one_sample_with_wrong_dtype___raises_error_with_correct_dtype[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_one_sample_with_wrong_dtype___raises_error_with_correct_dtype[library_init_kwargs]
…
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[library_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_many_sample___returns_valid_samples[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_many_sample___returns_valid_samples[library_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_many_sample_with_wrong_dtype___raises_error_with_correct_dtype[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_many_sample_with_wrong_dtype___raises_error_with_correct_dtype[library_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_one_sample___returns_valid_samples[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_one_sample___returns_valid_samples[library_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_one_sample_with_wrong_dtype___raises_error_with_correct_dtype[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_one_sample_with_wrong_dtype___raises_error_with_correct_dtype[library_init_kwargs]
…
This pull request removes 80 skipped tests and adds 80 skipped tests. Note that renamed tests count towards both.
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_waveforms___returns_valid_waveforms[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_waveforms_in_place___populates_valid_waveforms[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_waveforms_no_args___returns_valid_waveforms[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader___read_with_wrong_number_of_waveforms___throws_exception[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader_with_both_flags___read_waveforms___includes_both_timing_and_extended_properties[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader_with_extended_properties_flag___read_waveforms___only_includes_extended_properties[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader_with_none_flag___read_waveforms___minimal_waveform_data[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_multi_channel_reader_with_timing_flag___read_waveforms___only_includes_timing_data[grpc_init_kwargs]
tests.component.test_stream_readers_ai ‑ test___analog_single_channel_reader___read_into_undersized_waveform___throws_exception[grpc_init_kwargs]
…
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_into_undersized_waveforms___throws_exception[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_waveforms___returns_valid_waveforms[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_waveforms_in_place___populates_valid_waveforms[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_waveforms_no_args___returns_valid_waveforms[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader___read_with_wrong_number_of_waveforms___throws_exception[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader_with_both_flags___read_waveforms___includes_both_timing_and_extended_properties[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader_with_extended_properties_flag___read_waveforms___only_includes_extended_properties[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader_with_none_flag___read_waveforms___minimal_waveform_data[grpc_init_kwargs]
tests.component.readers.test_analog_multi_channel_reader ‑ test___analog_multi_channel_reader_with_timing_flag___read_waveforms___only_includes_timing_data[grpc_init_kwargs]
tests.component.readers.test_analog_single_channel_reader ‑ test___analog_single_channel_reader___read_into_undersized_waveform___throws_exception[grpc_init_kwargs]
…

@mikeprosserni mikeprosserni merged commit fd9912f into master Sep 3, 2025
27 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/stream-test-cleanup branch September 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants