Implement gRPC Waveform Support #878

mikeprosserni · 2025-11-03T20:02:03Z

This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request

What does this Pull Request accomplish?

For each of the nine interpreter methods in _grpc_interpreter.py:

read_analog_waveform()
read_analog_waveforms()
read_digital_waveform()
read_digital_waveforms()
read_new_digital_waveforms()
write_analog_waveform()
write_analog_waveforms()
write_digital_waveform()
write_digital_waveforms()

This PR implements the interpreter method by calling self._client.

Why should this Pull Request be merged?

AB#3424636

What testing has been done?

All of the waveform tests that had been disabled for grpc have now been enabled.

github-actions · 2025-11-03T20:03:10Z

Test Results

42 files ±0 42 suites ±0 1h 5m 9s ⏱️ + 3m 31s
3 119 tests ±0 2 540 ✅ + 81 579 💤 - 81 0 ❌ ±0
51 448 runs ±0 41 800 ✅ +810 9 648 💤 - 810 0 ❌ ±0

Results for commit f2cbbe0. ± Comparison against base commit f62b0ca.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.

tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_daq_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_daq_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_daq_error[library_init_kwargs]

tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_error[library_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_error[grpc_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_error[library_init_kwargs]

This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.

tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_daq_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_daq_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_daq_error[library_init_kwargs]

tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_error[library_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_error[grpc_init_kwargs]
tests.component.stream_writers.test_digital_multi_channel_writer ‑ test___digital_multi_channel_writer___write_waveforms_with_different_sample_counts___raises_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveforms_with_different_lengths___raises_error[library_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_error[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_do ‑ test___task___write_waveforms_with_different_sample_counts___raises_error[library_init_kwargs]

♻️ This comment has been updated with latest results.

generated/nidaqmx/_base_interpreter.py

generated/nidaqmx/_stubs/ni/protobuf/types/precision_timestamp_pb2.pyi

src/codegen/stub_generator.py

src/codegen/templates/_grpc_interpreter.py.mako

…-3424636-grpc-waveform-support

generated/nidaqmx/_grpc_interpreter.py

src/codegen/templates/_grpc_interpreter.py.mako

generated/nidaqmx/_grpc_interpreter.py

generated/nidaqmx/_waveform_utils.py

bkeryan

Looks good, assuming tests are now passing

Mike Prosser added 3 commits November 3, 2025 13:55

remove all "not implemented in GRPC" test markers

695ca70

implement methods in _grpc_interpreter.mako

f48fadd

update changelog

01c7e01

Mike Prosser added 24 commits November 3, 2025 15:24

update nidaqmx.proto and stub_generator.py

f79fe98

fix lint and some mypy issues

43b535a

generate .pyi for timestamp and waveform

366a181

_fix_ni_protobuf_imports()

fc7ca75

lint

6b6e32d

Sort proto files for deterministic generation order

4a98ac6

lint

d3e08b4

normalize line endings

6ac4caa

revert sorting fix

92e5983

lint

6e74004

fix some line endings

1c66bf9

fix stub_generator line endings

8c39249

write_bytes in stub_generator

44784cf

stub_generator cleanup

d80142b

force crlf endings

6741719

line endings

6fb3c2a

cleanup

da90124

cleanup

53fa057

fix line endings

bafb528

cleanup

c72d99e

cleanup

45d00bf

_get_num_samps_per_chan helper

758e88d

cleanup

1ab1022

improve changelog

66d6482

mikeprosserni mentioned this pull request Nov 10, 2025

[26Q1] Add features from DAQmx 26.0 release (Calculated Power and A, C-type Thermocouples) #876

Merged

3 tasks

mikeprosserni marked this pull request as ready for review November 10, 2025 16:51

mikeprosserni requested review from bkeryan, maxxboehme and zhindes as code owners November 10, 2025 16:51

mikeprosserni changed the title ~~[Under Construction] Implement gRPC Waveform Support~~ Implement gRPC Waveform Support Nov 10, 2025

zhindes approved these changes Nov 10, 2025

View reviewed changes

bkeryan requested changes Nov 10, 2025

View reviewed changes

Mike Prosser added 6 commits November 11, 2025 09:11

Merge remote-tracking branch 'origin/master' into users/mprosser/task…

8fbd911

…-3424636-grpc-waveform-support

_waveform_utils.py

59afa14

add ni-protobuf-types dependency and revert changes in stub_generator

50725fc

grpc interpreter cleanup

bad6ef4

use waveform_conversion methods

535b2be

cleanup

a48e3aa

bkeryan requested changes Nov 11, 2025

View reviewed changes

Mike Prosser added 6 commits November 11, 2025 13:46

target_waveform.timing = temp_waveform.timing

8900225

simplify read_analog_waveforms and read_digital_waveforms

0b50c8e

simplify write_analog_waveforms and write_digital_waveforms

f9b1d61

cleanup

3630130

revert _handle_rpc_error

da81015

cleanup

f2cbbe0

mikeprosserni requested a review from bkeryan November 11, 2025 21:45

bkeryan approved these changes Nov 11, 2025

View reviewed changes

mikeprosserni merged commit b97ffcd into master Nov 11, 2025
29 checks passed

mikeprosserni deleted the users/mprosser/task-3424636-grpc-waveform-support branch November 11, 2025 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement gRPC Waveform Support #878

Implement gRPC Waveform Support #878

Uh oh!

mikeprosserni commented Nov 3, 2025 •

edited by ni-github-admins

Loading

Uh oh!

github-actions bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkeryan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Implement gRPC Waveform Support #878

Implement gRPC Waveform Support #878

Uh oh!

Conversation

mikeprosserni commented Nov 3, 2025 • edited by ni-github-admins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this Pull Request accomplish?

Why should this Pull Request be merged?

What testing has been done?

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkeryan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mikeprosserni commented Nov 3, 2025 •

edited by ni-github-admins

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading