Fix timeout type in read_waveform() methods #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeprosserni
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
2 tasks
Contributor
zhindes
approved these changes
Nov 6, 2025
bkeryan
reviewed
Nov 6, 2025
| @@ -1,5 +1,6 @@ | |||
| """NI-DAQmx system classes.""" | |||
|
|
|||
| from nidaqmx.system import storage | |||
Collaborator
There was a problem hiding this comment.
Why did this start causing problems now and not previously?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
In some of the read_waveform() methods (in AnalogMultiChannelReader, AnalogSingleChannelReader, and DigitalMultiChannelReader), the timeout parameter was marked as 'int', when they should all be 'float'.
(Also,
/nidaqmx/system/__init__.pywas missing an import, which was causing unrelated mypy errors, which I have fixed.)Why should this Pull Request be merged?
AB#3462409
What testing has been done?
Ran lint, mypy, and all the autotests