Skip to content

Conversation

@mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Nov 13, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [] I've updated CHANGELOG.md if applicable.
  • [] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This is just a small detail, but now that there's a released 1.0 version of nitypes, that's what we should specify in the pyproject.toml. (Note that the version in poetry.lock was already 1.1.0.dev0, so this PR doesn't actually change the version of nitypes in use.)

Why should this Pull Request be merged?

AB#3229809

What testing has been done?

poetry lock
poetry install --all-extras --with examples
poetry run pytest

@mikeprosserni mikeprosserni marked this pull request as ready for review November 13, 2025 21:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Test Results

    42 files  ±0      42 suites  ±0   1h 5m 7s ⏱️ +52s
 3 119 tests ±0   2 540 ✅ ±0    579 💤 ±0  0 ❌ ±0 
51 448 runs  ±0  41 800 ✅ ±0  9 648 💤 ±0  0 ❌ ±0 

Results for commit a7245b8. ± Comparison against base commit b97ffcd.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions (poetry update nitypes)

@mikeprosserni mikeprosserni merged commit 2ab0a41 into master Nov 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants