Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

What does this Pull Request accomplish?

This PR changes how the numpy dependency is declared in pyproject.toml, to match how it is done in the nitypes repo. By making the dependency version logic match, this allows nipanel to use a newer, better version of numpy, as well as the latest version of nitypes.

Why should this Pull Request be merged?

This is needed so we can uptake the latest version of nitypes.

What testing has been done?

poetry lock
poetry install --with examples
poetry run pytest ./tests/unit

@mikeprosserni mikeprosserni marked this pull request as ready for review June 30, 2025 15:50
@mikeprosserni mikeprosserni requested a review from csjall as a code owner June 30, 2025 15:50
@github-actions
Copy link
Contributor

Test Results

   10 files  ±0     10 suites  ±0   25s ⏱️ -1s
  190 tests ±0    190 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 850 runs  ±0  1 850 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3395544. ± Comparison against base commit 983fe9d.

@mikeprosserni mikeprosserni merged commit fbd815c into main Jun 30, 2025
14 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/match-numpy-to-nitypes branch June 30, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants