Update nipanel to use has_start_time instead of has_timestamp. #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
mikeprosserni
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
In a previous submission to
nitypes-python, I added aTiming.get_start_timeproperty so that we could reference it innipanel-pythoninstead of usingget_timestamp.This change makes the
nipanel-pythonpart of this change.has_start_timeandhas_timestampare equivalent, so there is no functional change in this PR.In order to get access to
has_start_timeI had to update to the latest version ofnitypes.Why should this Pull Request be merged?
Finishes out AB#3166841
What testing has been done?
Unit tests, mypy, styleguide.