-
Couldn't load subscription status.
- Fork 0
Add a converter for datetime.datetime <--> Timestamp. #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
Test Results 10 files ± 0 10 suites ±0 21s ⏱️ ±0s Results for commit 1f08864. ± Comparison against base commit 2e9b3ba. This pull request removes 29 and adds 32 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Michael Johansen <[email protected]>
mikeprosserni
requested changes
Jul 31, 2025
bkeryan
reviewed
Jul 31, 2025
jfriedri-ni
approved these changes
Jul 31, 2025
Signed-off-by: Michael Johansen <[email protected]>
Signed-off-by: Michael Johansen <[email protected]>
Signed-off-by: Michael Johansen <[email protected]>
mikeprosserni
approved these changes
Jul 31, 2025
Signed-off-by: Michael Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds a
DateTimeConverterclass that converts pythondatetime.datetimeobjects to protobuftimestamp_pb2.Timestampobjects. I put this converter inbuiltin.pysince we do not own either type. They are included as built-in types for python/protobuf.timestamp_pb2.TimestamphasToDatetimeandFromDatetimefunctions which make this conversion easy.Once we add converters for
hightime.datetimeand/orbintime.DateTime, we'll have to update the python type checking logic to differentiate between these three different "datetime" types. I'm not including any of that logic in this PR.Why should this Pull Request be merged?
Implements part of AB#3166769
What testing has been done?
Unit tests, mypy, pyright, styleguide
I ran the all_types example and this is what shows up for

datetime: