Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

What does this Pull Request accomplish?

st.selectbox() should use key= to pass values automatically instead of using panel.set_value().

I've updated nidaqmx_analog_input_filtering example accordingly, and I've added an st.selectbox entry to the all_types example. I also added st.slider, st.progress, st.color_picker, st.multiselect, and st.radio entries to the all_types example, since all of them should also use key= to pass values automatically.

Why should this Pull Request be merged?

We want our examples to demonstrate best practices.

What testing has been done?

image

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Test Results

   10 files  ±0     10 suites  ±0   22s ⏱️ -1s
  221 tests ±0    221 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 160 runs  ±0  2 160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7c3b550. ± Comparison against base commit 2e9b3ba.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review July 31, 2025 15:24
@mikeprosserni mikeprosserni requested a review from csjall as a code owner July 31, 2025 15:24
@mikeprosserni mikeprosserni merged commit 67b57ce into main Jul 31, 2025
14 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/keyed-selectbox branch July 31, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants