Include module name in python type name strings to disambiguate types when converting.

[mjohanse-emr]

What does this Pull Request accomplish?

This change adds the module name to the python type name string that is used when determining what converter to use based on the python type.

This makes it so that the grpc conversion code can tell the difference between the different datetime and timedelta types:
bintime.DateTime, hightime.datetime, datetime.datetime
bintime.TimeDelta, hightime.timedelta, datetime.timedelta

To do this, I created a new method called get_candidate_strings which takes the list of "underlying parents" and returns the disambiguated type strings for those types. Meaning that they contain the module name as well as the type name.

I've updated all converters to specify their type string as module.type. Example: builtins.int
I've updated all collection converters to specify their type string to be like collections.abc.Collection[builtins.int]

I refactored the Converter class into three separate classes to handle the type naming in the base classes:

• Converter
• CollectionConverter
• CollectionConverter2D

Why should this Pull Request be merged?

So that the conversion code can tell the difference between different timing types and convert them appropriately.
Implements part of:

• AB#3166769
• AB#3164818

What testing has been done?

I updated the converter unit tests, which are passing. The rest of the unit tests pass as well. Also mypy, pyright, styleguide.

[github-actions]

Test Results

   10 files  ± 0     10 suites  ±0   24s ⏱️ -1s
  228 tests + 1    228 ✅ + 1  0 💤 ±0  0 ❌ ±0 
2 230 runs  +10  2 230 ✅ +10  0 💤 ±0  0 ❌ ±0 

Results for commit 1a61b7e. ± Comparison against base commit b5f258f.

This pull request removes 52 and adds 53 tests. Note that renamed tests count towards both.

tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[1-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[10-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[123-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[456.2-float]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[False-bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MixinIntEnum.VALUE11-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MyIntEnum.VALUE10-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MyIntFlags.VALUE1-int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[mystr-bytes]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[mystr-str]
…

tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[1-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[10-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[123-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[456.2-builtins.float]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[False-builtins.bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MixinIntEnum.VALUE11-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MyIntEnum.VALUE10-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[MyIntFlags.VALUE1-builtins.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[mystr-builtins.bytes]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[mystr-builtins.str]
…

♻️ This comment has been updated with latest results.

[mjohanse-emr]

This PR has a logical conflict with #128. Whichever PR gets in second will have to update the timedelta converter to return the type string datetime.timedelta.

[jfriedri-ni]

I would like us to strongly consider changing python_typename to always use '{module}.{class}' for every converter.