Paths should use pathlib.Path instead of str #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
hellovolcano
changed the title
Signed-off-by: Valerie Gleason 👌 <[email protected]>
hellovolcano
commented
Aug 12, 2025
mikeprosserni
approved these changes
Aug 12, 2025
bkeryan
reviewed
Aug 12, 2025
csjall
approved these changes
Aug 13, 2025
Signed-off-by: Valerie Gleason 👌 <[email protected]>
bkeryan
reviewed
Aug 13, 2025
| python_path = Path(sys.executable).resolve() | ||
|
|
||
| if sys.prefix not in python_path: | ||
| if python_path.is_relative_to(Path(sys.prefix)) is False: |
There was a problem hiding this comment.
Please don't write <condition> is False.
Two reasons:
- In this case,
<condition>already evaluates to a bool. If<condition> is Falseis good (it's not), then(<condition> is False) is Trueis better (it's not). - Python has the concept of "truthiness" and "falsiness", where other objects besides the bool literal
Falseare also "falsy":0,"",None,[], etc. Theisoperator checks object identity, which bypasses "falsiness": https://docs.python.org/3/reference/expressions.html#is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Changes the type of paths from string to pathlib.Path.
Why should this Pull Request be merged?
fixes #130
Ran examples locally
Unit tests, mypy, nps, bandit