Skip to content

Conversation

@csjall
Copy link
Collaborator

@csjall csjall commented Aug 28, 2025

What does this Pull Request accomplish?

Currently nipanel pulls in DiscoveryClient from the Measurement Plugin SDK. Update project to pull it from separate DiscoveryClient package.

Why should this Pull Request be merged?

Simplified dependencies.

What testing has been done?

  • Ran pytest
  • Run simple_graph example

@csjall csjall requested a review from mikeprosserni as a code owner August 28, 2025 15:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Test Results

   10 files  ±0     10 suites  ±0   30s ⏱️ -1s
  251 tests ±0    251 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 460 runs  ±0  2 460 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5d66c93. ± Comparison against base commit 56c166f.

♻️ This comment has been updated with latest results.

@csjall csjall enabled auto-merge (squash) August 28, 2025 16:07
@csjall csjall merged commit 45f0e3d into main Aug 28, 2025
14 checks passed
@csjall csjall deleted the users/jscholtz/discovery-client branch August 28, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants