Update python_panel_service.proto file to remove Disconnect and change Connect to OpenPanel #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR updates the proto file to remove the
Disconnect()method, and rename theConnect()method toOpenPanel(). The panel and the tests are updated accordingly. Since there's no longer aDisconnect(), the panel no longer supports thewithstatement.Why should this Pull Request be merged?
The .proto file needs to match the .proto file in ASW: https://ni.visualstudio.com/DevCentral/_git/ASW/pullrequest/961874
What testing has been done?
Ran the linter, mypy, and the tests.