github: Specify required permissions for CI and PR workflows #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeprosserni
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Make the CI and PR workflows work with
Workflow permissionsset toRead repository contents and packages permissionsin the repo's GitHub Actions settings.The https://github.com/EnricoMi/publish-unit-test-result-action action requires the ability to write to checks and PRs. Also, since this is a private repo, reading the repo contents is opt-in.
Why should this Pull Request be merged?
Principle of least privilege.
What testing has been done?
Tested with nitypes repo: ni/nitypes-python#53
I will not flip the switch in the settings until this is merged, to avoid disrupting other developers.