Expand enumerate_panels(), add support for with #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csjall
requested changes
May 29, 2025
csjall
changed the title
csjall
approved these changes
May 29, 2025
bkeryan
reviewed
Jun 3, 2025
Comment on lines
+14
to
+18
| if TYPE_CHECKING: | ||
| if sys.version_info >= (3, 11): | ||
| from typing import Self | ||
| else: | ||
| from typing_extensions import Self |
There was a problem hiding this comment.
We're not doing this anymore. Use typing_extensions directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
EnumeratePanelsin the .proto file, including the state of the panel (open or not) and the list of available value_ids.__enter__()and__exit__()to StreamlitPanel, so thatwithcan be used on panels.Why should this Pull Request be merged?
Implements AB#3140758
What testing has been done?
tests for PanelClient:
test___enumerate_panels_is_emptytest___open_panels___both_panels_open_and_in_memorytest___open_panels___close_panel_1_with_reset___panel_1_not_in_memorytest___open_panels___close_panel_1_without_reset___both_panels_in_memorytest___set_value___enumerate_panels_shows_valuetests for StreamlitPanel:
test___open_panel___panel_is_open_and_in_memorytest___with_panel___set_value___gets_same_valuetest___with_panel___opens_and_closes_panel