nipanel: Type check with Pyright in addition to mypy #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c:\Dev\nipanel-python\src\nipanel\converters\builtin.py c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:29:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:51:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:73:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:95:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:117:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:141:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:169:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:197:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:223:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\builtin.py:249:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride) c:\Dev\nipanel-python\src\nipanel\converters\protobuf_types.py c:\Dev\nipanel-python\src\nipanel\converters\protobuf_types.py:45:9 - error: Method "to_python_value" overrides class "Converter" in an incompatible manner Parameter 2 name mismatch: base parameter is named "protobuf_message", override parameter is named "protobuf_value" (reportIncompatibleMethodOverride)
c:\Dev\nipanel-python\tests\conftest.py c:\Dev\nipanel-python\tests\conftest.py:20:23 - error: Argument of type "_LoggingPool" cannot be assigned to parameter "thread_pool" of type "ThreadPoolExecutor" in function "start" "_LoggingPool" is not assignable to "ThreadPoolExecutor" (reportArgumentType)
mikeprosserni
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a dependency on
pyright, which is a Python package that wraps the Pyright node.js module.Fix errors identified by Pyright:
error: Method "to_python_value" overrides class "Converter" in an incompatible manner./to specify that the parameters before it are positional-only, so their names do not need to match.error: Argument of type "_LoggingPool" cannot be assigned to parameter "thread_pool" of type "ThreadPoolExecutor" in function "start"grpc.serverexpect aThreadPoolExecutor.logging_pool.pool()returns a_LoggingPoolobject, which uses composition to wrapThreadPoolExecutor.Executorand_LoggingPoolshould inherit fromExecutor.Why should this Pull Request be merged?
Mypy and Pyright have different behavior in some cases and we should test with both.
What testing has been done?
Ran mypy and pyright locally.