Skip to content

Add Analog Input Example #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jun 25, 2025
Merged

Add Analog Input Example #85

merged 41 commits into from
Jun 25, 2025

Conversation

@DilmiWickramanayake
Copy link
Contributor

@DilmiWickramanayake DilmiWickramanayake commented Jun 19, 2025 •
edited
Loading

What does this Pull Request accomplish?

Acquired data from analog input examples and displayed on graph

Why should this Pull Request be merged?

AB#3067912

What testing has been done?

Manual testing with simulated hardware Dev1/ai0, Dev1/ai1

Streamlit Webpage

image
image

mikeprosserni
mikeprosserni requested changes Jun 19, 2025
View reviewed changes
bkeryan
bkeryan requested changes Jun 19, 2025
View reviewed changes
csjall
csjall requested changes Jun 19, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

Test Results

   10 files  ±0     10 suites  ±0   17s ⏱️ -5s
  150 tests ±0    150 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 470 runs  ±0  1 470 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d8ddecd. ± Comparison against base commit dcaf336.

♻️ This comment has been updated with latest results.

csjall
csjall approved these changes Jun 20, 2025
View reviewed changes
bkeryan
bkeryan approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w/suggestions

mikeprosserni
mikeprosserni approved these changes Jun 23, 2025
View reviewed changes
jfriedri-ni
jfriedri-ni reviewed Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@jfriedri-ni jfriedri-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, these are comments on variable names and the UI presentation. Please let me know if you have any questions 😄

bkeryan
bkeryan reviewed Jun 24, 2025
View reviewed changes
bkeryan
bkeryan reviewed Jun 24, 2025
View reviewed changes
hellovolcano and others added 5 commits June 24, 2025 14:25
bkeryan
bkeryan reviewed Jun 24, 2025
View reviewed changes
Dilmi Wickramanayake added 5 commits June 24, 2025 15:45
@bkeryan
Copy link
Collaborator

bkeryan commented Jun 24, 2025 

Check failure on line 24 in examples/nidaqmx/nidaqmx_continuous_analog_input.py


GitHub Actions
/ Run CI / Check nipanel / Check nipanel

Argument of type "Literal[1000]" cannot be assigned to parameter "number_of_samples_per_channel" of type "UnsetNumSamplesSentinel" in function "read"
  "Literal[1000]" is not assignable to "UnsetNumSamplesSentinel" (reportArgumentType)

nidaqmx-python doesn't have type hints so either add a # pyright: ignore[reportArgumentType] on this line or edit pyproject.toml to configure pyright to exclude this example.

hellovolcano
hellovolcano reviewed Jun 25, 2025
View reviewed changes
@DilmiWickramanayake DilmiWickramanayake merged commit 5a027ba into main Jun 25, 2025
14 checks passed
@mikeprosserni mikeprosserni mentioned this pull request Jun 27, 2025
Merged
@hellovolcano hellovolcano deleted the users/DilmiWickramanayake/Analog_Input branch August 12, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellovolcano hellovolcano hellovolcano left review comments

@bkeryan bkeryan bkeryan approved these changes

@mikeprosserni mikeprosserni mikeprosserni approved these changes

@csjall csjall csjall approved these changes

@jfriedri-ni jfriedri-ni jfriedri-ni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DilmiWickramanayake @bkeryan @csjall @hellovolcano @mikeprosserni @jfriedri-ni