-
Notifications
You must be signed in to change notification settings - Fork 0
Add a converter to/from Double2DArray. #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 10 files ± 0 10 suites ±0 19s ⏱️ -3s Results for commit f06cdb9. ± Comparison against base commit dcaf336. This pull request removes 5 and adds 44 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Michael Johansen <[email protected]>
Signed-off-by: Michael Johansen <[email protected]>
|
Can you add the new 2D types to the new all_types example? You can just add them to |
Signed-off-by: Michael Johansen <[email protected]>
What does this Pull Request accomplish?
Allows panel clients to read/write 2D collections of floats using
set_value()andget_value(). The most common expected use case is a list of list of floats, but this change supports tuples, sets, and frozen sets as well.This change includes:
Collection[Collection[float]]to/fromDouble2DArray_get_best_matching_type()to allow for detecting nested python collections.Why should this Pull Request be merged?
Satisfies the requirements AB#3166107 (at least for now**)
** Caveat: There are discussions going on about what protobuf type to use for 2D collections. I used
Double2DArrayfor this change as a means to prove out that we can detect nested collections in_convert.py. The actual implementation of the converter may change if we decide to use a different protobuf type to pass these 2D collections over the wire.What testing has been done?
Unit tests, mypy, ni-python-styleguide.