fix: Error in converting results/steps to dataframe when status is none#115
Merged
SSSantosh18 merged 9 commits intoni:masterfrom Mar 21, 2025
Merged
Conversation
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
SSSantosh18
reviewed
Mar 20, 2025
nisystemlink/clients/testmonitor/utilities/_dataframe_utilities.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
SSSantosh18
approved these changes
Mar 20, 2025
nisystemlink/clients/testmonitor/utilities/_dataframe_utilities.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/testmonitor/utilities/_dataframe_utilities.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
vignesh261201
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
SSSantosh18
reviewed
Mar 20, 2025
nisystemlink/clients/testmonitor/utilities/_dataframe_utilities.py
Outdated
Show resolved
Hide resolved
SSSantosh18
changed the title
SSSantosh18
changed the title
Signed-off-by: Vigneshwaran-Selvaraj_adi <vigneshwaran.selvaraj@analog.com>
rbell517
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
It fixes the error in convert to dataframe utilities when the step/result status is None.
Why should this Pull Request be merged?
Utility throws error when converting result/steps with status as None to dataframe
What testing has been done?
Updated the existing test to test this changes