Conversation
SSadaiyappan-NI
approved these changes
Apr 18, 2025
rbell517
approved these changes
Apr 18, 2025
SSSantosh18
approved these changes
Apr 21, 2025
…ython into users/sam/fix-string-numbers-as-numeric-condition
SSadaiyappan-NI
approved these changes
Apr 24, 2025
rbell517
approved these changes
Apr 24, 2025
SSSantosh18
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
discretevalue ofNumericConditionValueis set toList[Union[StringFloat, StrictInt]]. Used StrictFloat and StrictInt because we only need integer and float values to be stored here and not string of numbers. Ifint/floatare used, pydantic tries to convert the string of numbers into float/int.discretevalue ofStringConditionValueis set toStrictStr. UsedStrictStrbeause, we only want strings to be stored here and not any other datatypes. Ifstris used, pydantic converts any other datatypes to string and stores it.Why should this Pull Request be merged?
What testing has been done?
Automated integration tests are included.