Conversation
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…hri2k2/nisystemlink-clients-python into users/sam-rishi/fix-spec-response-model
…hub.com/shri2k2/nisystemlink-clients-python into users/sam-rishi/feat-spec-dataframe-utility
…model Response Model for Query Specs with Only Optional Fields
| } | ||
|
|
||
|
|
||
| def convert_specs_to_dataframe( |
There was a problem hiding this comment.
We didn't discuss it in the meeting this morning, but what you do with the conditions mapping function would impact what you'd want the index to be. Its also not clear to me with this parameter if that would mean you're creating a MultiIndex index or a new column that is the serialized combination of these columns. I would expect a MultiIndex would be more useful. Either way doing this would impact your data access in ways that probably would not help usability. Workspace and product IDs are not very commonly known, compared with the their name and part number equivalents.
I'm inclined to leave this unindexed or indexed by id if it is available in the projection (not specId) and let the caller reindex in whatever way makes sense for them.
What does this Pull Request accomplish?
column projectionand a function forcondition formattingin the parameters.column projectionis not passed, all the columns will be included in the dataframe as a default approach.condition formattingis not passed, default condition formatting will be done. In the default condition formatting, the column headers will be incondition_conditionName(conditionUnit)format if the condition value isNumericConditionValueandcondition_conditionNameformat if the condition value isStringConditionValue. The column value will be in[min: num; max; step], num, numformat where data within[]is condition range and other num values are discrete values if the condition value isNumericConditionValueandstr, str, strwhere the str values are discrete values if the condition value isStringConditionValue.column projectionis passed and eitherCONDITION_NAMEorCONDITION_VALUESis not included, thecondition formattingwon't be done and conditions columns will be excluded in the dataframe.Why should this Pull Request be merged?
What testing has been done?