fix: Enable null value for results properties#99
Merged
SSadaiyappan-NI merged 5 commits intomasterfrom Mar 6, 2025
Merged
Conversation
1 task
added 2 commits
March 5, 2025 17:26
SSSantosh18
approved these changes
Mar 5, 2025
SSSantosh18
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
1 task
rbell517
approved these changes
Mar 5, 2025
SSadaiyappan-NI
deleted the
users/priya/fix/enable-null-for-results-property-value
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Test results can be created with
nullforpropertiesvalue. eg. {"author": null}. The PR merge pipeline is failing while querying such results from the test env. To accommodate this, the results client has been modified to accept Optional value for properties.Why should this Pull Request be merged?
Pipeline failure - link
What testing has been done?
Ran automated tests against dev and test env