Minor improvements to Scalar class documentation and code #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'other' to reduce potential confusion between the data member 'value' and the formal argument with the same name. Made all arguments in comparison functions positional.
…minate duplicated string constants. Signed-off-by: Kosta Ilic <[email protected]>
…cumentation based on failures I was when running 'poetry run python -m doctest src\nitypes\scalar.py -v'. Signed-off-by: Kosta Ilic <[email protected]>
…utomated test failure, so I reverted those few changes. Signed-off-by: Kosta Ilic <[email protected]>
KostaIlic2
changed the title
…h previous documentation heading. Signed-off-by: Kosta Ilic <[email protected]>
Signed-off-by: Kosta Ilic <[email protected]>
…e it consistent with other similar sentences. Signed-off-by: Kosta Ilic <[email protected]>
KostaIlic2
commented
Dec 17, 2025
KostaIlic2
commented
Dec 17, 2025
KostaIlic2
commented
Dec 17, 2025
KostaIlic2
commented
Dec 17, 2025
…her petty documentation improvements. Signed-off-by: Kosta Ilic <[email protected]>
Signed-off-by: Kosta Ilic <[email protected]>
bkeryan
requested changes
Dec 18, 2025
Author
|
Inspired by @bkeryan's statement that equality comparison operators are always supported I decided to split comparison section of the document between equality and order comparison operators. I like new organization better. |
Signed-off-by: Kosta Ilic <[email protected]>
… by a comment from bkeryan. I like this organization better than what we had before. Signed-off-by: Kosta Ilic <[email protected]>
Author
|
@bkeryan, I see we use of slightly different terminology and orthography within scalar.py. Some were there before this PR. Here is what I found with the version of the file in this PR:
Would you like me to address this inconsistency as part of this PR? |
…penetrate the arcane error message. Signed-off-by: Kosta Ilic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR resolves issues #230 and #231.
Summary of changes:
Why should this Pull Request be merged?
The changes increase value of the library.
What testing has been done?
I executed prescribed static code and automated test protocols. Since there were no functional changes, I did not introduce any new automated tests.