complex: Add support for NumPy arrays of complex integers #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
commented
May 7, 2025
Contributor
bkeryan
commented
May 7, 2025
csjall
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a new subpackage,
nitypes.complex, containing:ComplexInt32DType, representing a complex integer equivalent toNIComplexI16.convert_complexfunction that can be used to convert NumPy arrays or scalars of complex numbers, includingComplexInt32DType.Why should this Pull Request be merged?
Required for complex waveform support.
AB#3093661 - Define NumPy-compatible complex integer types
What testing has been done?
Wrote new unit tests and doctests.