Reverse Indices for Digital Waveform Signals

src/nitypes/waveform/_digital/_waveform.py

@@ -173,9 +173,8 @@ class DigitalWaveform(Generic[TDigitalState]):
 
     * :attr:`DigitalWaveformSignal.signal_index` - The position in the :attr:`DigitalWaveform.signals`
       collection (0-based from the first signal). signal_index 0 is the rightmost column in the data.
-    * :attr:`DigitalWaveformSignal.column_index` - The position in the :attr:`DigitalWaveform.data`
-      array's second dimension (0-based from the first column). column_index 0 is the leftmost column
-      in the data.
+    * :attr:`DigitalWaveformSignal.column_index` - The column in the :attr:`DigitalWaveform.data`
+      array, e.g. `waveform.data[:, column_index]`. column_index 0 is the leftmost column in the data.
 
     These indices are reversed with respect to each other. signal_index 0 (line 0) corresponds to
     the highest column_index, and the highest signal_index (the highest line) corresponds to
@@ -838,7 +837,7 @@ def __init__(
         ):
             extended_properties = ExtendedPropertyDictionary(extended_properties)
         self._extended_properties = extended_properties
-        self._extended_properties.on_key_changed = self._on_extended_property_changed
+        self._extended_properties._on_key_changed = self._on_extended_property_changed
 
         if timing is None:
             timing = Timing.empty

src/nitypes/waveform/_extended_properties.py

@@ -4,6 +4,8 @@
 from collections.abc import Callable, Iterator, Mapping, MutableMapping
 from typing import TYPE_CHECKING
 
+from typing_extensions import TypeAlias
+
 from nitypes.waveform.typing import ExtendedPropertyValue
 
 # Extended property keys
@@ -12,7 +14,7 @@
 UNIT_DESCRIPTION = "NI_UnitDescription"
 
 if TYPE_CHECKING:
-    OnKeyChangedCallback = Callable[[str], None]
+    OnKeyChangedCallback: TypeAlias = Callable[[str], None]
 
 
 class ExtendedPropertyDictionary(MutableMapping[str, ExtendedPropertyValue]):
@@ -32,15 +34,6 @@ def __init__(self, properties: Mapping[str, ExtendedPropertyValue] | None = None
         if properties is not None:
             self._properties.update(properties)
 
-    @property
-    def on_key_changed(self) -> OnKeyChangedCallback | None:
-        """Callback invoked when a key is set or deleted."""
-        return self._on_key_changed
-
-    @on_key_changed.setter
-    def on_key_changed(self, value: OnKeyChangedCallback | None) -> None:
-        self._on_key_changed = value
-
     def __len__(self) -> int:
         """Return len(self)."""
         return len(self._properties)