Skip to content

Enable error reporting on diff pipeline#193

Draft
Karl-G1 wants to merge 5 commits intomainfrom
dev/diff_error
Draft

Enable error reporting on diff pipeline#193
Karl-G1 wants to merge 5 commits intomainfrom
dev/diff_error

Conversation

@Karl-G1
Copy link
Contributor

@Karl-G1 Karl-G1 commented Jun 8, 2023

What does this Pull Request accomplish?

This PR is an attempt to fail the build when the diff pipeline errors out.

Why should this Pull Request be merged?

PR #192 build succeeded but should have failed with git_utilities.py was deleted.

What testing has been done?

Pending PR build

@buckd
Copy link
Collaborator

buckd commented Jun 8, 2023

This failed for the intended reason, but also would have failed because an error was reported due to pip not being the latest version. I'd like to see the result of a build without git_utilities.py removed and see if the diff stage passes then. I know we also see errors returned during diff when we try to close LabVIEW if it's already been closed. That should be ignorable, but might cause the build to fail with this change.

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

ClearCache.vi.png

capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants