fix: Bump version properly when running on main #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the semantic-release workflow to properly bump versions and create GitHub releases by splitting the semantic-release process into explicit changelog, version, and publish steps.
Key Changes:
- Added explicit
semantic-release changelogcall before version bumping - Separated GitHub release creation into its own workflow step using
semantic-release publish --skip-build - Maintained the existing pattern of building and publishing to PyPI separately using Poetry and trusted publishing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
semantic-release wasn't bumping versions properly or creating github releases. This should fix that
Implementation
manually call
changelogandversionwith semantic-revision then callpublish.We're not using semantic-release to write to pypi because we're using trusted publishing.
Checklist