feat(core): Implement ApiSession and ApiSessionUtils with session management #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartheeswaran-ni
requested changes
Oct 14, 2025
Collaborator
kartheeswaran-ni
left a comment
kartheeswaran-ni
left a comment
There was a problem hiding this comment.
I'm waiting to see the final version with the actual usage of this utility along with docs as we discussed offline.
…ngress support | with failing tests
…ead of 'sessionKey'
…ith detailed error messages
priya-ni
requested changes
Oct 22, 2025
…pdate session validation logic
…b for cookie value retrieval
… API session handling
richie-ni
requested review from
cameronwaterman,
m-akinc and
rajsite
as code owners
priya-ni
approved these changes
Oct 23, 2025
kartheeswaran-ni
approved these changes
Oct 23, 2025
kartheeswaran-ni
requested changes
Oct 23, 2025
Collaborator
kartheeswaran-ni
left a comment
kartheeswaran-ni
left a comment
There was a problem hiding this comment.
I would like to take a look once all the comments are addressed.
…g logic; add tests for session creation
… for improved API interaction
kartheeswaran-ni
approved these changes
Oct 24, 2025
… test instances for consistency
Collaborator
Author
m-akinc
approved these changes
Oct 24, 2025
Collaborator
m-akinc
left a comment
m-akinc
left a comment
There was a problem hiding this comment.
Approving, but I left some feedback.
rajsite
reviewed
Oct 24, 2025
rajsite
reviewed
Oct 24, 2025
…and refactor API request handling in DataSourceBase
rajsite
approved these changes
Oct 27, 2025
richie-ni
changed the title
1 task
Ahalya-ni
pushed a commit
that referenced
this pull request
Oct 28, 2025
## [4.29.0](v4.28.0...v4.29.0) (2025-10-28) ### Features * **core:** Implement ApiSession and ApiSessionUtils with session management ([#434](#434)) ([3e5a2f4](3e5a2f4))
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of bypassing webserver for the API that will be used in the Dataframe datasource, this pull request introduces a utility class,
ApiSessionUtils, for managing API session keys with caching.👩💻 Implementation
ApiSessionUtilsclass inapi-session.utils.tsto handle API session creation, caching, and validation, including a 5-minute expiry buffer and error handling with event publishing.ApiSessioninterface to standardize the session object structure.Reference
The implementation in this PR is inspired by the API session service from the Test Insights App
Prototype PR : #407
🧪 Testing
✅ Checklist