Skip to content

[WIP] WIP to address feedback on cancellation handling#519

Merged
MileaRobertStefan merged 1 commit intousers/rmilea/2025/tagsdatasouce/cancel_requestfrom
copilot/sub-pr-517
Nov 12, 2025
Merged

[WIP] WIP to address feedback on cancellation handling#519
MileaRobertStefan merged 1 commit intousers/rmilea/2025/tagsdatasouce/cancel_requestfrom
copilot/sub-pr-517

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 12, 2025

Addressing feedback on request cancellation handling in refresh process.

Plan:

  • Replace merge operator with forkJoin in fetchTagsHistory$ method (lines 108-109)
  • Update import statement to include forkJoin instead of merge
  • Verify the change maintains correct behavior and waits for all observables to complete
  • Run tests to ensure the change doesn't break existing functionality
  • Run linter and build to validate the change

Context:
The current implementation uses merge which emits values as soon as any source observable emits. This causes the map at line 109 to return tagsDecimatedHistory before all observables complete, resulting in incomplete data. Using forkJoin will ensure all observables complete before returning the combined result.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@MileaRobertStefan MileaRobertStefan marked this pull request as ready for review November 12, 2025 14:13
@MileaRobertStefan MileaRobertStefan merged commit b8ae410 into users/rmilea/2025/tagsdatasouce/cancel_request Nov 12, 2025
1 check failed
@MileaRobertStefan MileaRobertStefan deleted the copilot/sub-pr-517 branch November 12, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants