[WIP] WIP to address feedback on cancellation handling#519
Merged
MileaRobertStefan merged 1 commit intousers/rmilea/2025/tagsdatasouce/cancel_requestfrom Nov 12, 2025
Merged
Conversation
1 task
b8ae410
into
users/rmilea/2025/tagsdatasouce/cancel_request
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing feedback on request cancellation handling in refresh process.
Plan:
mergeoperator withforkJoininfetchTagsHistory$method (lines 108-109)forkJoininstead ofmergeContext:
The current implementation uses
mergewhich emits values as soon as any source observable emits. This causes themapat line 109 to returntagsDecimatedHistorybefore all observables complete, resulting in incomplete data. UsingforkJoinwill ensure all observables complete before returning the combined result.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.