fix(systems): Cancel ongoing requests when refreshing query #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-bob-1
requested review from
cameronwaterman,
chotea,
m-akinc,
rajsite and
stefanc18
as code owners
robert-bob-1
force-pushed
the
users/robob/systemsDataSource-useObservables
branch
from
a7cd31d to
3849740
Compare
stefanc18
requested changes
Nov 14, 2025
Collaborator
stefanc18
left a comment
stefanc18
left a comment
There was a problem hiding this comment.
Talked offline with Robert, he'll refactor the code to avoid duplication and ensure we have testing coverage.
rajsite
reviewed
Nov 17, 2025
added 4 commits
December 9, 2025 10:04
… into users/robob/systemsDataSource-useObservables
… into users/robob/systemsDataSource-useObservables
rajsite
approved these changes
Jan 13, 2026
stefanc18
approved these changes
Jan 14, 2026
… into users/robob/systemsDataSource-useObservables
…th correct filter and correct number of 'replace' template calls
kartheeswaran-ni
pushed a commit
that referenced
this pull request
Jan 28, 2026
## [4.119.1](v4.119.0...v4.119.1) (2026-01-27) ### Bug Fixes * **systems:** Cancel ongoing requests when refreshing query ([#526](#526)) ([bafcefa](bafcefa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This solves the bug for the Systems Data source
Bug 3463192: Grafana | System Data source | Refreshing data source queries before the currently running query is completed, the ongoing query is not cancelled as expected.
Whenever the user refreshes the query, the query route is called without cancelling the previous requests for the same route.
👩💻 Implementation
Changed the return type of the methods from Promise to Observable.
Use the Observable methods from DataSourceBase file for running the queries.
Add a
getWorkspacesObservable method since this route is recalled in tests.🧪 Testing
Manually tested That requests from the systems data source get cancelled. You can see the requests in the network tab are in red since i cancelled them from the UI
✅ Checklist