Skip to content

fix(systems): Fix flaky query builder value selection and improve variable dropdown assertions#713

Open
BlankaOnodi wants to merge 1 commit intomainfrom
users/bonodi/systems-fix-test-3813278
Open

fix(systems): Fix flaky query builder value selection and improve variable dropdown assertions#713
BlankaOnodi wants to merge 1 commit intomainfrom
users/bonodi/systems-fix-test-3813278

Conversation

@BlankaOnodi
Copy link
Copy Markdown
Collaborator

Pull Request

🤨 Rationale

Fix flaky query builder value selection and improve variable dropdown assertions:

  • click({ force: true }) uses coordinates that can land on a wrong option when the dropdown is clipped. evaluate(el => el.click()) is coordinate-free
  • the missing input:focus wait caused dropped characters.
  • toHaveCount catches cases where the filter returns all results instead of the expected subset.

Task 3813278: update selectQueryBuilderValueOption to be more reliable

👩‍💻 Implementation

Replace click({ force: true }) with evaluate(el => el.click()) for dropdown option selection, add input:focuswait before typing in plain text fields, and add a toHaveCount assertion for the variable dropdown.

🧪 Testing

Verified all acceptance tests pass locally by running the affected test files.

✅ Checklist

@BlankaOnodi BlankaOnodi marked this pull request as ready for review April 6, 2026 15:59
@BlankaOnodi BlankaOnodi requested review from a team, chotea and stefanc18 as code owners April 6, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant