fix(systems): Fix flaky query builder value selection and improve variable dropdown assertions#713
Open
BlankaOnodi wants to merge 1 commit intomainfrom
Open
fix(systems): Fix flaky query builder value selection and improve variable dropdown assertions#713BlankaOnodi wants to merge 1 commit intomainfrom
BlankaOnodi wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fix flaky query builder value selection and improve variable dropdown assertions:
Task 3813278: update selectQueryBuilderValueOption to be more reliable
👩💻 Implementation
Replace click({ force: true }) with evaluate(el => el.click()) for dropdown option selection, add input:focuswait before typing in plain text fields, and add a toHaveCount assertion for the variable dropdown.
🧪 Testing
Verified all acceptance tests pass locally by running the affected test files.
✅ Checklist