Skip to content

Conversation

@iuiu34
Copy link

@iuiu34 iuiu34 commented Jan 19, 2024

#35

  • simple developer mode instructions
  • (kinda) generical way to declare theme args in each widget
    my knowledge in ts, is way less than py, i'll try to work on improve the generic methods
  • color, background_color, size, font declared as themes in all widgets (backend & frontend)

questions

  • (concept) do you like the overall "generic theme" idea of this PR?
    in case so
  • (backend) is clean to have the args in each py function? or would be cleaner to define theme: dict?
  • (frontend) is clean to call const {color, font, backgroundColor, size, primaryColor, textColor} = getTheme(props); every time? or would be better to move to theme=getTheme(props);?
  • (random) why readme.md is lower case not upper?

@iuiu34 iuiu34 changed the title button background_color custom theme for each widget Jan 20, 2024
@iuiu34
Copy link
Author

iuiu34 commented Jan 23, 2024

which nomenclature do you follow for the naming?

for the theme, shall i inherit tsx ones? but map mixedCase to snake_case?

In particular,

  • font_size
  • color_primary
  • color_text
  • font_family
  • color_bg_container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant