Skip to content

Fix panic in object with SHT_NOBITS #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nichmor merged 1 commit into from
Jan 15, 2026
Merged

Fix panic in object with SHT_NOBITS #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/elf/rewriter/elf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ pub(crate) fn find_move_sections(
if !section.is_alloc() {
continue;
}
if section.sh_offset == 0 {
// Note that it is allowed for SHT_NOBITS sections to have sh_offset == 0,
// but we never move them, so we must be careful to skip them here.
if section.sh_offset == 0 && section.sh_type != elf::SHT_NOBITS {
// Newly added section that needs to be assigned to a segment,
// or a section that has already been flagged for moving.
move_sections.push(section.id());
Expand Down