chore(lints): introduce typos-cli config in Cargo.toml and handle typos#2390
Open
mkatychev wants to merge 8 commits intonickel-lang:masterfrom
Open
chore(lints): introduce typos-cli config in Cargo.toml and handle typos#2390mkatychev wants to merge 8 commits intonickel-lang:masterfrom
Cargo.toml and handle typos#2390mkatychev wants to merge 8 commits intonickel-lang:masterfrom
Conversation
Contributor
Author
|
Not sure where this line/column diff is coming from 🤔 https://github.com/tweag/nickel/actions/runs/18698880001/job/53323091230?pr=2390#step:5:1848 |
mkatychev
commented
Oct 22, 2025
mkatychev
commented
Oct 22, 2025
Member
|
It may be best to redo this after #2302 is finished -- otherwise there will be a lot of conflicts |
Contributor
Author
|
Sounds good, all the manual steps have been documented so I can just rerun all of it. |
mkatychev
force-pushed
the
chore/typos-cli-lint
branch
from
45acfbc to
ac49c90
Compare
Contributor
Bencher Reportsd 'seach' 'search' ./**/*.rs sd 'seach' 'search' ...(fd -e rs) sd 'dyamic' 'dynamic' ./**/*.md sd 'dyamic' 'dynamic' ...(fd) sd 'wich' 'which' ...(fd) sd 'contining' 'containing' ./**/*.rs sd 'contining' 'containing' ...(fd) sd 'contine' 'continue' ...(fd) sd 'evalution' 'evaluation' ...(fd) typos --no-check-filenames sd 'overrided' 'overridden' ...(fd) ^sd 'doens' 'doesn' ./**/*.rs ^sd 'shrinked' 'shrunk' ./**/*.rs sd 'represention' 'representation' ...(fd) ^sd 'confing' 'config' ./**/*.md ^sd 'chaning' 'changing' ./**/*.rs
mkatychev
force-pushed
the
chore/typos-cli-lint
branch
from
ac49c90 to
f6bee86
Compare
Contributor
Author
|
@jneem this should be ready for review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related PR: topiary/topiary#832
Cargo.tomlhttps://github.com/tweag/nickel/blob/d77b6c35ec2db5200a7f343bdf21ec6d5a0e1576/Cargo.toml#L147-L157
typos -won the project