Request cancellation for language server#2523
Merged
L0r3m1p5um merged 4 commits intonickel-lang:masterfrom Feb 26, 2026
Merged
Conversation
…on causing requests not to be cancelled.
Contributor
jneem
reviewed
Feb 23, 2026
jneem
reviewed
Feb 23, 2026
jneem
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements client cancellation of language server requests via the
$/cancelRequestnotification. There's a limitation on what requests can be canceled. The request has to be waiting in the queue. If handling of the request has already begun, that request will be completed normally even if a cancellation notification is received. The server will never proactively cancel a request, this only cancels requests when requested by the client.