[Bug Fix] Fix the issue that current item index may be changed after rotation#201
[Bug Fix] Fix the issue that current item index may be changed after rotation#201flexme wants to merge 1 commit intonicklockwood:masterfrom
Conversation
|
BTW, if this is merged, can you release a new version to Cocoapods? Thanks! |
|
Nick, can you merge this? We need it and the updated cocoapods to fix the bug in our app. Thanks! |
|
Hmm, is this project still being maintained? |
michafaw
left a comment
There was a problem hiding this comment.
Works well in our project with no noticeable side effects. 👍
(Bug can be reproduced by rotating when on the last item. It flips to the next to last item. iPad Air, horizontal scrolling, with navigation bar)
|
For me this fixed the problem when rotating from landscape to portrait while on the last item. But the bug can still be reproduced when rotating from portrait to landscape while on the last item. (Iphone SE,7,7+). It jumps to the second to last item. Any suggestions? |
|
It hurts to see this amazing library no longer mantained, tbh. |
|
@AlexAstilean this workaround works well for my usecase: http://pastebin.com/tHPaqsaN |
Fixes an issue where current item index was being changed on device rotation.
This fixes the issue #200 .
Basically when the device is rotated, the scroll view's contentSize may be changed since itemSize may be changed (by method
updateScrollViewDimensions). However changingcontentSizewill result incontentOffsetbeing changed by UIKit, thenScrollView.scrollViewDidScrollwill be invoked and change the current item index...This fix ensures that we update the contentOffset based on current item index when contentSize is changed.