Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions honcho/environ.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,17 @@ def parse(content):
"""
values = {}
for line in content.splitlines():
lexer = shlex.shlex(line, posix=True)
tokens = list(lexer)

# parses the assignment statement
if len(tokens) < 3:
try:
name, value = line.split('=', 1)
except ValueError:
continue

name, op = tokens[:2]
value = ''.join(tokens[2:])

if op != '=':
continue
if not re.match(r'[A-Za-z_][A-Za-z_0-9]*', name):
name = name.strip()
if not re.match(r'[A-Za-z_][A-Za-z_0-9.]*', name):
continue

lexer = shlex.shlex(value, posix=True)
value = ''.join(lexer)
value = value.replace(r'\n', '\n')
value = value.replace(r'\t', '\t')
values[name] = value
Expand Down
7 changes: 7 additions & 0 deletions tests/test_environ.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@
'NEWLINES': 'foo\nbar',
'DOLLAR': 'foo\\$bar'}
],
[
# "." in value
r"""
MYVAR.SUB=value
""",
{'MYVAR.SUB': 'value'}
]
])
def test_environ_parse(content, commands):
content = textwrap.dedent(content)
Expand Down