Fix node attribute-index updates for SET statements#48
Draft
Fix node attribute-index updates for SET statements#48
Conversation
Co-authored-by: niclasko <5694442+niclasko@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Cant Select Updated Node
Fix node attribute-index updates for SET statements
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where nodes could not be found by their updated property values after using a SET statement. Previously when updating a node property with SET, the node-attribute-index was not updated to reflect the new property values.
Problem
When updating a node property with the SET statement (e.g.,
SET n+={id: 'a2'}), the actual property was updated in the node, but the node-attribute-index still pointed to the old value. This meant that queries likeMATCH (n:AttributesType {id: 'a2'})would return no results, even though the node with that property value existed.Solution
I added functionality to scan nodes directly when property lookup fails through the index, and to update the index accordingly:
removeLookupNodeIdfunction to remove node IDs from indexesmatchNodePropertiesfunction to:Example
The following now works as expected:
The solution is minimal and maintains backward compatibility with the rest of the codebase.
Fixes #2.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.