Skip to content

Fix node attribute-index updates for SET statements#48

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-2
Draft

Fix node attribute-index updates for SET statements#48
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-2

Conversation

Copy link

Copilot AI commented May 26, 2025

This PR fixes an issue where nodes could not be found by their updated property values after using a SET statement. Previously when updating a node property with SET, the node-attribute-index was not updated to reflect the new property values.

Problem

When updating a node property with the SET statement (e.g., SET n+={id: 'a2'}), the actual property was updated in the node, but the node-attribute-index still pointed to the old value. This meant that queries like MATCH (n:AttributesType {id: 'a2'}) would return no results, even though the node with that property value existed.

Solution

I added functionality to scan nodes directly when property lookup fails through the index, and to update the index accordingly:

  1. Added a removeLookupNodeId function to remove node IDs from indexes
  2. Modified the matchNodeProperties function to:
    • Search all nodes directly when a property lookup through the index returns no results
    • Add found nodes to the index for future queries

Example

The following now works as expected:

// Create a node
CREATE (n:AttributesType {id: 'a'}) return n

// Update its property
MATCH (n:AttributesType {id: 'a'}) SET n+={id: 'a2'} RETURN n

// Query by the new property value (previously returned 0 nodes)
MATCH (n:AttributesType {id: 'a2'}) RETURN n

The solution is minimal and maintains backward compatibility with the rest of the codebase.

Fixes #2.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org
    • Triggering command: /usr/bin/fwupdmgr refresh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: niclasko <5694442+niclasko@users.noreply.github.com>
Copilot AI changed the title [WIP] Cant Select Updated Node Fix node attribute-index updates for SET statements May 26, 2025
Copilot AI requested a review from niclasko May 26, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant Select Updated Node

2 participants