Skip to content

Update dependencies#72

Closed
djc wants to merge 7 commits intonico-abram:mainfrom
djc:update-deps
Closed

Update dependencies#72
djc wants to merge 7 commits intonico-abram:mainfrom
djc:update-deps

Conversation

@djc
Copy link
Collaborator

@djc djc commented Aug 20, 2025

@nico-abram I don't have easy access to Windows environments, but let me know if you'd like someone to help with trivial stuff like this.

@nico-abram
Copy link
Owner

@djc
Thanks for the patch. I could indeed use help, I haven't been using rust much the last few years so you could say I'm "rusty" :P

I tried to build this locally and ran into the following errors:

Details

error[E0432]: unresolved importwindows::Win32::System::SystemServices::SE_SYSTEM_PROFILE_NAME--> src\lib.rs:33:5 | 33 | use windows::Win32::System::SystemServices::SE_SYSTEM_PROFILE_NAME; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ noSE_SYSTEM_PROFILE_NAMEinWin32::System::SystemServices`

error[E0433]: failed to resolve: could not find SymbolCache in symsrv
--> src\lib.rs:690:25
|
690 | symsrv::SymbolCache::new(symsrv::get_symbol_path_from_environment(), false);
| ^^^^^^^^^^^ could not find SymbolCache in symsrv

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:91:20
|
91 | if ret.0 == 0 {
| ^ unknown field

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:174:92
|
174 | LookupPrivilegeValueW(None, SE_SYSTEM_PROFILE_NAME, &mut privs.Privileges[0].Luid).0 == 0
| ^ unknown field

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:179:89
|
179 | if unsafe { OpenProcessToken(GetCurrentProcess(), TOKEN_ADJUST_PRIVILEGES, &mut pt).0 == 0 } {
| ^ unknown field

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:183:15
|
183 | if adjust.0 == 0 {
| ^ unknown field

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:191:12
|
191 | if ret.0 == 0 {
| ^ unknown field

error[E0609]: no field 0 on type std::result::Result<(), windows_result::error::Error>
--> src\lib.rs:209:12
|
209 | if ret.0 == 0 {
| ^ unknown field

error[E0308]: mismatched types
--> src\lib.rs:230:13
|
229 | let ret = TraceSetInformation(
| ------------------- arguments to this function are incorrect
230 | None,
| ^^^^ expected CONTROLTRACE_HANDLE, found Option<_>
|
= note: expected struct CONTROLTRACE_HANDLE
found enum Option<_>
note: function defined here
--> C:\Users\Nick12.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\windows-0.61.3\src\Windows\Win32\System\Diagnostics\Etw\mod.rs:494:15
|
494 | pub unsafe fn TraceSetInformation(sessionhandle: CONTROLTRACE_HANDLE, informationclass: TRACE_QUERY_INFO_C...
| ^^^^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
--> src\lib.rs:300:13
|
299 | let control_stop_retcode = ControlTraceA(
| ------------- arguments to this function are incorrect
300 | None,
| ^^^^ expected CONTROLTRACE_HANDLE, found Option<_>
|
= note: expected struct CONTROLTRACE_HANDLE
found enum Option<_>
note: function defined here
--> C:\Users\Nick12.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\windows-0.61.3\src\Windows\Win32\System\Diagnostics\Etw\mod.rs:7:15
|
7 | pub unsafe fn ControlTraceA(tracehandle: CONTROLTRACE_HANDLE, instancename: P1, properties: *mut EVENT...
| ^^^^^^^^^^^^^

error[E0609]: no field 0 on type PROCESSTRACE_HANDLE
--> src\lib.rs:486:32
|
486 | if trace_processing_handle.0 == INVALID_HANDLE_VALUE.0 as u64 {
| ^ unknown field
|
= note: available field is: Value

error[E0308]: mismatched types
--> src\lib.rs:525:25
|
525 | NtResumeProcess(context.target_process_handle.0);
| --------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected isize, found *mut c_void
| |
| arguments to this function are incorrect
|
= note: expected type isize
found raw pointer *mut c_void

error[E0282]: type annotations needed
--> src\lib.rs:711:51
|
711 | let pdb_ctx = match owned_pdb(file_contents.to_vec()) {
| ^^^^^^^^^^^^^ cannot infer type

Some errors have detailed explanations: E0282, E0308, E0432, E0433, E0609.
For more information about an error, try rustc --explain E0282.
error: could not compile blondie (lib) due to 13 previous errors
`

I might see if I can get it to build with the updated deps after new years.

@djc
Copy link
Collaborator Author

djc commented Dec 29, 2025

Do you want to also invite me on crates.io? (cargo owner -a djc should do it.)

Also, for some reason the GitHub Actions don't seem to be running here. If you can get that fixed, that would make it much easier for me to iterate on my PR to get the compilation errors fixed.

@nico-abram
Copy link
Owner

Sent the crates.io invite

That's odd. The workflow seems to run for commits on the main branch and it has this trigger:

on:
  push:
    branches:
      - "**"
  pull_request:
    branches:
      - "**"

I noticed they were failing because of using the v2 cache action, but I don't think they'd fail to trigger on PRs because of that ... And I think I recall them running on the dependabot PRs (although the logs for those runs seem to have long expired)

@djc
Copy link
Collaborator Author

djc commented Dec 29, 2025

Maybe have a look at /blondie/settings/actions to see if it is disabled somehow? I've sometimes seen that happen automatically when a repo is inactive for a while (though I thought it was restricted to repos that have scheduled workflows).

In other repos, I just have a bare pull_request: (on a line by itself) in on:, maybe that would work better?

@nico-abram
Copy link
Owner

Actions were already enabled in settings.

I changed to this after skimming the latest docs from github

  pull_request:
    types: [opened, synchronize, reopened, closed]

I tested opening a PR and they ran, but I'm not certain if they'll trigger on a PR from a fork.

@djc
Copy link
Collaborator Author

djc commented Dec 29, 2025

Pushed a rebase, looks like it triggered CI. Will have a look.

@djc
Copy link
Collaborator Author

djc commented Jan 5, 2026

@djc djc closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants