Conversation
|
@djc I tried to build this locally and ran into the following errors: Details
error[E0433]: failed to resolve: could not find error[E0609]: no field error[E0609]: no field error[E0609]: no field error[E0609]: no field error[E0609]: no field error[E0609]: no field error[E0308]: mismatched types error[E0308]: mismatched types error[E0609]: no field error[E0308]: mismatched types error[E0282]: type annotations needed Some errors have detailed explanations: E0282, E0308, E0432, E0433, E0609. I might see if I can get it to build with the updated deps after new years. |
|
Do you want to also invite me on crates.io? ( Also, for some reason the GitHub Actions don't seem to be running here. If you can get that fixed, that would make it much easier for me to iterate on my PR to get the compilation errors fixed. |
|
Sent the crates.io invite That's odd. The workflow seems to run for commits on the main branch and it has this trigger: on:
push:
branches:
- "**"
pull_request:
branches:
- "**"I noticed they were failing because of using the v2 cache action, but I don't think they'd fail to trigger on PRs because of that ... And I think I recall them running on the dependabot PRs (although the logs for those runs seem to have long expired) |
|
Maybe have a look at In other repos, I just have a bare |
|
Actions were already enabled in settings. I changed to this after skimming the latest docs from github pull_request:
types: [opened, synchronize, reopened, closed]I tested opening a PR and they ran, but I'm not certain if they'll trigger on a PR from a fork. |
|
Pushed a rebase, looks like it triggered CI. Will have a look. |
@nico-abram I don't have easy access to Windows environments, but let me know if you'd like someone to help with trivial stuff like this.