build system now supports more build environments#30
Open
BasisDeveloper wants to merge 1 commit intonico:mainfrom
Open
build system now supports more build environments#30BasisDeveloper wants to merge 1 commit intonico:mainfrom
BasisDeveloper wants to merge 1 commit intonico:mainfrom
Conversation
Before if you were compiling with Clang on Windows using MSYS2 or any environment that wasn't Windows native it would try and use MSVC build flags no matter what compiler was selected. Now that isn't a problem. (I changed the styling of the CMake file to add more whitespace, sorry if that annoys anyone, you can edit it to your liking.)
5a6b7cf to
77f83c7
Compare
|
Can confirm that this is needed to fix: @nico Could this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before if you were compiling with Clang on Windows using MSYS2 or any environment that wasn't Windows native it would try and use MSVC build flags no matter what compiler was selected. I fixed that issue with my edits. Change anything you dislike.
(By the way, I've never contributed to someone else's project, if I'm suppose to open an issue first no matter what, I'm genuinely sorry)