Skip to content

Comments

🧩 Fix: custom components theme+ job cancellation bug + add modals + block config view + generator view#45

Merged
nicofretti merged 9 commits intodevelopfrom
feat/replace-modals
Dec 1, 2025
Merged

🧩 Fix: custom components theme+ job cancellation bug + add modals + block config view + generator view#45
nicofretti merged 9 commits intodevelopfrom
feat/replace-modals

Conversation

@nicofretti
Copy link
Owner

@nicofretti nicofretti commented Nov 27, 2025

Description

  • Adds job cancellation checkpoints at 4 critical locations in the pipeline execution flow
  • Replaces browser confirm() calls with a custom ConfirmModal component using Radix UI
  • Fixes theme synchronization between shadcn and Primer component libraries

Related Issue

Checklist

  • Code follows project style guidelines
  • Comments explain "why" not "what"
  • Documentation updated (if needed)
  • No debug code or console statements
  • make format passes
  • make pre-merge passes
  • PR update from develop branch
  • Copilot review run and addressed

@nicofretti nicofretti marked this pull request as ready for review December 1, 2025 18:40
@nicofretti nicofretti requested a review from Copilot December 1, 2025 18:41
@nicofretti nicofretti self-assigned this Dec 1, 2025
@nicofretti nicofretti changed the base branch from main to develop December 1, 2025 18:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a comprehensive fix for job cancellation logic to prevent background processing from continuing after cancellation, adds a reusable modal component to replace browser confirm dialogs, fixes theme management to use shadcn as the source of truth, and improves the Generator validation workflow.

  • Adds job cancellation checkpoints at 4 critical locations in the pipeline execution flow
  • Replaces browser confirm() calls with a custom ConfirmModal component using Radix UI
  • Fixes theme synchronization between shadcn and Primer component libraries

Reviewed changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
tests/test_job_cancellation.py Comprehensive test suite for job cancellation at various checkpoints
lib/workflow.py Adds cancellation checks before block execution in normal and multiplier pipelines
lib/job_processor.py Critical fix to prevent continuing to next seed after inner loop cancellation
frontend/src/components/ui/confirm-modal.tsx New reusable confirmation dialog component with variants
frontend/src/App.tsx Refactors theme management to use shadcn as source of truth
frontend/src/pages/Generator.tsx Removes auto-revalidation, adds manual verify button, improves UX
frontend/src/components/pipeline-editor/BlockConfigPanel.tsx Fixes Monaco Editor to use controlled value prop with proper sync logic
frontend/src/components/ui/sonner.tsx Updates theme integration to use resolvedTheme
pyproject.toml Adds pytest-timeout dependency for test stability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

height="200px"
defaultLanguage="python"
defaultValue={value}
value={value}
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing Monaco Editor from defaultValue to value prop makes it a fully controlled component, which can cause performance issues and cursor jumping during typing. Monaco Editor is designed to use defaultValue for initialization. The sync logic should handle updates by calling editor.setValue() instead of changing the value prop. Consider reverting to defaultValue and using the editor instance API for updates.

Copilot uses AI. Check for mistakes.
@nicofretti nicofretti changed the title 🧩 Fix: theme in the custom components + add modals + block config view + generator view 🧩 Fix: custom components theme+ job cancellation bug + add modals + block config view + generator view Dec 1, 2025
@nicofretti nicofretti merged commit b7e47a9 into develop Dec 1, 2025
1 check passed
@nicofretti nicofretti deleted the feat/replace-modals branch December 15, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧩 Fix: theme in the custom components

1 participant