fix test

Signed-off-by: Stefan Niederhauser <[email protected]>

Author: nidi3

graphviz-java/src/main/java/guru/nidi/graphviz/model/Serializer.java

@@ -41,9 +41,7 @@ private void toplevelGraph(MutableGraph graph) {
         if (!graph.name.isEmpty()) {
             str.append(SimpleLabel.of(graph.name).serialized()).append(' ');
         }
-        str.append("{\n");
         doGraph(graph, useDir);
-        str.append('}');
     }
 
     private void subGraph(MutableGraph graph, boolean useDir) {
@@ -52,12 +50,11 @@ private void subGraph(MutableGraph graph, boolean useDir) {
                     .append(Label.of((graph.cluster ? "cluster_" : "") + graph.name).serialized())
                     .append(' ');
         }
-        str.append("{\n");
         doGraph(graph, useDir);
-        str.append('}');
     }
 
     private void doGraph(MutableGraph graph, boolean useDir) {
+        str.append("{\n");
         if (useDir && graph.graphAttrs.get("dir") == null) {
             attributes("edge", Attributes.attr("dir", graph.directed ? "forward" : "none"));
         }
@@ -86,6 +83,7 @@ private void doGraph(MutableGraph graph, boolean useDir) {
 
         edges(nodes, useDir);
         edges(graphs, useDir);
+        str.append('}');
     }
 
     private boolean hasDifferentlyDirectedSubgraphs(MutableGraph graph) {

graphviz-java/src/test/java/guru/nidi/graphviz/CodeAnalysisTest.java

@@ -89,7 +89,9 @@ protected PmdResult analyzePmd() {
                         .ignore("JUnitTestsShouldIncludeAssert", "LocalVariableCouldBeFinal", "UnusedLocalVariable"))
                 .because("It's a test", In.loc("*Test")
                         .ignore("ExcessiveMethodLength"))
-                .because("It's a bug in PMD?", In.clazz(MutableNode.class).ignore("ConstructorCallsOverridableMethod"))
+                .because("It's a bug in PMD?",
+                        In.clazz(MutableNode.class).ignore("ConstructorCallsOverridableMethod"),
+                        In.loc("Serializer#doGraph").ignore("ConsecutiveLiteralAppends"))
                 .because("There are a lot of colors", In.clazz(Color.class)
                         .ignore("FieldDeclarationsShouldBeAtStartOfClass"))
                 .because("it's ok here",
@@ -129,7 +131,7 @@ protected CpdResult analyzeCpd() {
                 .apply(PmdConfigs.cpdIgnoreEqualsHashCodeToString())
                 .because("It's java",
                         In.loc("*Graph").ignore("Graph(strict, directed, cluster, name,", "if (strict != graph.strict) {"))
-                .just(In.locs("GraphvizGraalEngine","GraphvizNashornEngine").ignore("void doInit()"));
+                .just(In.locs("GraphvizGraalEngine", "GraphvizNashornEngine").ignore("void doInit()"));
         return new CpdAnalyzer(AnalyzerConfig.maven().main(), 36, collector).analyze();
     }