Fix bug with default config (#70)

When no nightfall dlp config file was provided, the module was sending a bad default request payload

Author: evanfuller

.circleci/config.yml

@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  nightfall_code_scanner: nightfall/nightfall_code_scanner@2.2.0
+  nightfall_code_scanner: nightfall/nightfall_code_scanner@3.0.0
 
 jobs:
   build:

.nightfalldlp/config.json

@@ -5,31 +5,38 @@
       "detectors": [
         {
           "minNumFindings": 1,
-          "minConfidence": "VERY_UNLIKELY",
+          "minConfidence": "LIKELY",
           "displayName": "cc num",
           "detectorType": "NIGHTFALL_DETECTOR",
           "nightfallDetector": "CREDIT_CARD_NUMBER"
         },
         {
           "minNumFindings": 1,
-          "minConfidence": "VERY_UNLIKELY",
+          "minConfidence": "LIKELY",
           "displayName": "phone num",
           "detectorType": "NIGHTFALL_DETECTOR",
           "nightfallDetector": "PHONE_NUMBER"
         },
         {
           "minNumFindings": 1,
-          "minConfidence": "VERY_UNLIKELY",
+          "minConfidence": "LIKELY",
           "displayName": "api key",
           "detectorType": "NIGHTFALL_DETECTOR",
           "nightfallDetector": "API_KEY"
         },
         {
           "minNumFindings": 1,
-          "minConfidence": "VERY_UNLIKELY",
+          "minConfidence": "LIKELY",
           "displayName": "crypto key",
           "detectorType": "NIGHTFALL_DETECTOR",
           "nightfallDetector": "CRYPTOGRAPHIC_KEY"
+        },
+        {
+          "minNumFindings": 1,
+          "minConfidence": "LIKELY",
+          "displayName": "password",
+          "detectorType": "NIGHTFALL_DETECTOR",
+          "nightfallDetector": "PASSWORD_IN_CODE"
         }
       ],
       "logicalOp": "ANY"
@@ -46,3 +53,4 @@
   "fileInclusionList": ["*"],
   "fileExclusionList": ["README.md"]
 }
+

internal/clients/diffreviewer/circleci/circleci_service_test.go

@@ -292,6 +292,7 @@ func (c *circleCiTestSuite) TestLoadEmptyConfig() {
 		NightfallAPIKey: apiKey,
 		NightfallDetectionRules: []nf.DetectionRule{
 			{
+				Name: "default detection rule",
 				Detectors: []nf.Detector{
 					{
 						DetectorType:      nf.DetectorTypeNightfallDetector,
@@ -315,6 +316,7 @@ func (c *circleCiTestSuite) TestLoadEmptyConfig() {
 						MinNumFindings:    1,
 					},
 				},
+				LogicalOp: nf.LogicalOpAny,
 			},
 		},
 		NightfallMaxNumberRoutines: nightfallconfig.DefaultMaxNumberRoutines,

internal/clients/diffreviewer/github/github_service_test.go

@@ -281,6 +281,7 @@ func (g *githubTestSuite) TestLoadEmptyConfig() {
 		NightfallAPIKey: apiKey,
 		NightfallDetectionRules: []nf.DetectionRule{
 			{
+				Name: "default detection rule",
 				Detectors: []nf.Detector{
 					{
 						DetectorType:      nf.DetectorTypeNightfallDetector,
@@ -304,6 +305,7 @@ func (g *githubTestSuite) TestLoadEmptyConfig() {
 						MinNumFindings:    1,
 					},
 				},
+				LogicalOp: nf.LogicalOpAny,
 			},
 		},
 		NightfallMaxNumberRoutines: nightfallconfig.DefaultMaxNumberRoutines,

internal/nightfallconfig/nightfall_config.go

@@ -25,6 +25,7 @@ const (
 var defaultNightfallConfig = &ConfigFile{
 	DetectionRules: []nf.DetectionRule{
 		{
+			Name: "default detection rule",
 			Detectors: []nf.Detector{
 				{
 					MinNumFindings:    1,
@@ -48,6 +49,7 @@ var defaultNightfallConfig = &ConfigFile{
 					DisplayName:       "PASSWORD_IN_CODE",
 				},
 			},
+			LogicalOp: nf.LogicalOpAny,
 		},
 	},
 	MaxNumberRoutines: DefaultMaxNumberRoutines,

internal/nightfallconfig/nightfall_config_test.go

@@ -70,6 +70,7 @@ func TestGetNightfallConfigMissingConfigFile(t *testing.T) {
 	expectedConfig := &ConfigFile{
 		DetectionRules: []nf.DetectionRule{
 			{
+				Name: "default detection rule",
 				Detectors: []nf.Detector{
 					{
 						MinNumFindings:    1,
@@ -93,6 +94,7 @@ func TestGetNightfallConfigMissingConfigFile(t *testing.T) {
 						NightfallDetector: "PASSWORD_IN_CODE",
 					},
 				},
+				LogicalOp: nf.LogicalOpAny,
 			},
 		},
 		MaxNumberRoutines: DefaultMaxNumberRoutines,