Skip to content

Fix error handling in fetch#59

Open
aredridel wants to merge 1 commit intonightscout:masterfrom
aredridel:fix-error-handling
Open

Fix error handling in fetch#59
aredridel wants to merge 1 commit intonightscout:masterfrom
aredridel:fix-error-handling

Conversation

@aredridel
Copy link

This converts fetch errors into actual errors, which should prevent authorization failure response bodies from being passed as authorization tokens to future requests

@aredridel
Copy link
Author

This should also keep this project in the owners of the API's good graces too.

@bewest
Copy link
Member

bewest commented Jun 4, 2023

Looks good, sorry for getting around to this so late. You may be interested in this as well: https://github.com/nightscout/nightscout-connect.
Since request is deprecated, I'm looking at replacing the headache of managing m plugins to just 1.

@aredridel
Copy link
Author

I will check that out!

@aredridel
Copy link
Author

Looks like that version is unaffected since axios's defaults are to throw if status code is < 100 or >= 300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants