Conversation
|
Thanks for the patch. |
Add Math Primitives in single file Taken from these commits: * Completely overhaul serialization and deserialization - Inochi2D/inochi2d@63fac27 * Fix deserialization - Inochi2D/inochi2d@bc1cb61
|
Yeah actually those commits deleted those files. I now updated this change to that. Basically |
|
Sorry, I cannot accept the change that might break with existing code base. |
|
That's fine, I don't really care but it just makes it simpler to port changes when codebases are similar and not too divergent.
That's tricky... just look at Inochi2D/inochi2d@63fac27 ... |
|
I think we should first set up proper integration testing, especially for serialization and save/load functionality. nijilive has some transformers and other features that are independent from inochi2d, and these could potentially corrupt users’ project files during save/load — which would be even harder to accept than a simple crash. For the other parts, most of the UI changes previously didn’t require touching the core function libraries, so those could be resolved through cherry-picking and manual verification. |
I tried to update
nijigeneratetoi2d-imgui(see nijigenerate/nijigenerate#84)Unfortunately it's major PITA because everything's tightly coupled and Luna has no idea how to use Git so it's all massive commit dumps that contain unrelated changes/everything...
Basically one of the commits that updates inochi-creator to
i2d-imguineeds this math module.And I can't cherry-pick just this module because commits contain shitload of other stuff and even this depends on new serializer.
Anyway this implementation comes from these commits: